Conversation
- `CollectionNovelSearchScreen.kt`: 작품 검색을 위한 임시 화면 및 레이아웃 구현 - `CollectionNovelSearchAppBar.kt`: 작품 검색 화면 전용 앱바 추가 - `CollectionNovelSection.kt`: 작품 추가 카드 클릭 시 `onAddNovelClick` 콜백이 실행되도록 수정하고, 클릭 피드백을 위한 `clickable` 및 `clip` 속성 적용 - `CollectionNavHost.kt`: 작품 검색 경로(`COLLECTION_NOVEL_SEARCH_ROUTE`) 정의 및 내비게이션 그래프 내 화면 추가
- `CollectionNovelSearchField.kt`: 작품 제목 및 작가 검색을 위한 검색 필드 컴포저블 구현 - `CollectionNovelSearchAppBar.kt`: 완료 버튼의 활성화 상태에 따른 색상 변경 로직 추가 및 `isCompleteEnabled` 파라미터 정의
- `CollectionNovelSearchField.kt`: 기존의 정적 텍스트를 `BasicTextField`로 교체하여 실제 입력이 가능하도록 수정하고, 검색어 삭제를 위한 클리어 버튼 추가 - `CollectionNovelSearchScreen.kt`: `searchQuery` 상태 관리 로직을 추가하고, `LaunchedEffect`를 통해 화면 진입 시 검색 필드 자동 포커스 및 키보드 노출 기능 구현
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
💤 Files with no reviewable changes (1)
Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review. Walkthrough컬렉션 앱바를 공통화하고 제목과 완료 액션을 지원하도록 변경했습니다. 컬렉션 생성 화면에 작품 검색 이동을 연결했습니다. 검색어 입력, 초기 포커스, 키보드 표시를 포함한 작품 검색 화면과 검색 필드를 추가했습니다. Changes컬렉션 작품 검색
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This PR adds the collection work search screen UI and navigation without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant CollectionCreateScreen
participant CollectionNovelSection
participant CollectionNavHost
participant CollectionNovelSearchScreen
participant CollectionNovelSearchField
CollectionCreateScreen->>CollectionNovelSection: 작품 추가 콜백 연결
CollectionNovelSection->>CollectionCreateScreen: 작품 추가 클릭
CollectionCreateScreen->>CollectionNavHost: 작품 검색 라우트 요청
CollectionNavHost->>CollectionNovelSearchScreen: 검색 화면 표시
CollectionNovelSearchScreen->>CollectionNovelSearchField: 검색어와 포커스 요청자 전달
CollectionNovelSearchField->>CollectionNovelSearchScreen: 검색어 변경 또는 초기화 전달
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| color = Black, | ||
| style = WebsosoTheme.typography.title2, | ||
| ) | ||
| title?.let { |
| onAddNovelClick: () -> Unit, | ||
| modifier: Modifier = Modifier, | ||
| ) { | ||
| val addCardShape = RoundedCornerShape(8.dp) |
Contributor
There was a problem hiding this comment.
한 함수내에서 사용하는 속성값은 그냥 그대로 변수 안만들고 사용하는게 보기 편할 것 같습니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
rememberSaveable로 관리합니다.검증
./gradlew :feature:collection:compileDebugKotlin ktlintCheck --console=plain📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
Screen_recording_20260818_202225.mp4
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
feat/935feat/936Summary by CodeRabbit